AnalysisPluginV0 typing improvements and fixes #1456
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
- Coverage 92.43% 92.43% -0.01%
==========================================
Files 370 370
Lines 20833 20816 -17
==========================================
- Hits 19258 19242 -16
+ Misses 1575 1574 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dorpvom
requested changes
Mar 16, 2026
Member
dorpvom
left a comment
dorpvom
left a comment
There was a problem hiding this comment.
Why is this called "convert TagColor" and then the "change of the TagColor" is only like 5 lines of the 50?
convert TagColor class to Enum to make sure custom plugins don't use arbitrary strings for Tag.color
jstucke
changed the title
Collaborator
Author
You are totally right. I improved the wording |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnalysisPluginV0 typing improvements
TagColorclass to Enum to make sure custom plugins don't use arbitrary strings forTag.color